Skip to content

fix: Fixed issue where a level component's iid component reference was assigned a previous layer#71

Merged
Cammin merged 1 commit intoCammin:masterfrom
ctzcs:fix-bug
Mar 23, 2026
Merged

fix: Fixed issue where a level component's iid component reference was assigned a previous layer#71
Cammin merged 1 commit intoCammin:masterfrom
ctzcs:fix-bug

Conversation

@ctzcs
Copy link
Copy Markdown
Contributor

@ctzcs ctzcs commented Mar 22, 2026

Here should be level's iid but it had been iid of last layer.

@ctzcs
Copy link
Copy Markdown
Contributor Author

ctzcs commented Mar 22, 2026

@Cammin please check this!

@Cammin
Copy link
Copy Markdown
Owner

Cammin commented Mar 22, 2026

Ah interesting, thank you! I do want to investigate this a bit.
I was also curious, do you know of a way to rewrite the commit note so the semantic version changelog is slightly more suited? I would like it to be formatted like:
fix: Fixed issue where a level component's iid component reference was assigned a previous layer

@ctzcs ctzcs changed the title Fix wrong iid reference in LDtkComponentLevel Iid field fix: Fixed issue where a level component's iid component reference was assigned a previous layer Mar 22, 2026
@Cammin
Copy link
Copy Markdown
Owner

Cammin commented Mar 22, 2026

Not necessarily the pull request title. The actual commit. This is something I've wanted to figure out for all my pull requests and haven't found out yet, it is partly why I haven't gotten to them soon enough 😅

@Cammin
Copy link
Copy Markdown
Owner

Cammin commented Mar 22, 2026

Like, if there's a way I have control over that, etc. there probably is a way and I just need to look into it

@ctzcs
Copy link
Copy Markdown
Contributor Author

ctzcs commented Mar 22, 2026

Like, if there's a way I have control over that, etc. there probably is a way and I just need to look into it比如,如果我有办法控制那个,等等,可能确实有办法,只是我需要去研究一下。

I just tried to figured out and changed the title.haha

@ctzcs
Copy link
Copy Markdown
Contributor Author

ctzcs commented Mar 22, 2026

Now it should be right! @Cammin

@Cammin
Copy link
Copy Markdown
Owner

Cammin commented Mar 22, 2026

Awesome! Thanks for the swift work, hopefully didn't burden you much, haha

@ctzcs
Copy link
Copy Markdown
Contributor Author

ctzcs commented Mar 22, 2026

Awesome! Thanks for the swift work, hopefully didn't burden you much, haha太棒了!感谢你的快速工作,希望没给你添太多麻烦,哈哈

With pleasure. : )

@Cammin
Copy link
Copy Markdown
Owner

Cammin commented Mar 22, 2026

I'm going to review it a bit before going ahead with it, I think there might be a way to grab a cached value instead of getcomponent. But if not, then I'll complete the request

@ctzcs
Copy link
Copy Markdown
Contributor Author

ctzcs commented Mar 22, 2026

I'm going to review it a bit before going ahead with it, I think there might be a way to grab a cached value instead of getcomponent. But if not, then I'll complete the request我先仔细检查一下再继续,或许有办法获取缓存值而非使用 getcomponent。如果不行,我会完成这个请求。

That's great!

@Cammin
Copy link
Copy Markdown
Owner

Cammin commented Mar 23, 2026

I made some changes here: 1054564
It basically adds a second new variable to separate the ref of the level and layer components, as they were getting mixed up before.
I'm surprised this bug has been around for so long. Thank you for spotting it :)
The update should be out soon

@Cammin Cammin merged commit bf953f1 into Cammin:master Mar 23, 2026
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 6.12.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants